Add new API function H5Pget_actual_select_io_mode() #2974
Conversation
fortnern
requested review from
lrknox,
derobins,
byrnHDF,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
added
Merge - To 1.14
mode if at least one byte selected
… actual_select_io_mode
| HGOTO_ERROR(H5E_VFL, H5E_READERROR, FAIL, "driver read vector request failed"); | ||
|
|
||
| /* Set actual selection I/O mode, if this is a raw data operation */ | ||
| if (is_raw) { |
There was a problem hiding this comment.
Since the scalar I/O pathway in H5FD_write/H5FD_read is checking that the raw data I/O is size > 0, should we be checking that as well in the vector I/O pathway, or does that matter?
There was a problem hiding this comment.
So we could do this for vector without too much problem, but to implement it for selection we'd have to check all the dataspaces which could be expensive for the "_id" routines which would have to resolve all of those IDs into H5S_t *s. Vector already avoids modifying the io mode when passed 0 vectors (count == 0),, and that could easily be added to selection. I suppose you could make an argument for reverting this change for scalar (it is making the callback after all), though I'd have to change the test code.
There was a problem hiding this comment.
I decided to revert the checking for size == 0. There's a fairly lengthy comment explaining some of this behavior in the test now.
| herr_t ret_value = SUCCEED; /* return value */ | ||
|
|
||
| FUNC_ENTER_API(FAIL) | ||
| H5TRACE2("e", "ix", plist_id, actual_selection_io_mode); |
There was a problem hiding this comment.
Should this be i*Iu for the trace macro? Looks like that's used for both unsigned and uint32_t
There was a problem hiding this comment.
This is what bin/trace spits out. It might be an error but it seems to be the same for other similar functions.
There was a problem hiding this comment.
It seems inconsistent based on
Line 1204 in b916ce2
There was a problem hiding this comment.
It might be getting confused by the "/* out */"
There was a problem hiding this comment.
This looks like a bug in the bin/trace script that affects many existing API functions. I think the fix is outside the scope of this PR
testpar/t_select_io_dset.c
Outdated
|
|
||
| /* Exception case: This will turn off selection I/O landing at H5FD__mpio_write() */ | ||
| if ((test_mode & TEST_TCONV_BUF_TOO_SMALL) && !(test_mode & TEST_IN_PLACE_TCONV)) | ||
| no_selection_io_cause_write_expected |= H5D_SEL_IO_TCONV_BUF_TOO_SMALL; | ||
| else | ||
| no_selection_io_cause_write_expected |= H5D_SEL_IO_NO_VECTOR_OR_SELECTION_IO_CB; | ||
| // no_selection_io_cause_write_expected |= H5D_SEL_IO_NO_VECTOR_OR_SELECTION_IO_CB; |
There was a problem hiding this comment.
Looks like commenting out this line will cause the setting of selection I/O below to only occur in the else clause. Is that intended?
There was a problem hiding this comment.
I reworked this section, I think it's cleaner now
|
Just some minor comments/possible fixes but otherwise this looks good to me |
selection I/O even if there are no selections (because the callback is still being made with H5FD_MEM_DRAW)
fortnern
changed the title
This function allows the user to determine if the library performed selection I/O, vector I/O, or scalar (legacy) I/O during the last HDF5 operation performed with the provided DXPL. Expanded existing tests to check this functionality.
* Correct ld in format strings in cmpd_dset.c (#3697) Removes clang warnings * Clean up comments. (#3695) * Add NVidia compiler support and CI (#3686) * Work around Theta system issue failure in links test (#3710) When the Subfiling VFD is enabled, the links test may try to initialize the Subfiling VFD and call MPI_Init_thread. On Theta, this appears to have an issue that will cause the links test to fail. Reworked the test to check for the same conditions in a more roundabout way that doesn't involved initializing the Subfiling VFD * Fix issue with unmatched messages in ph5diff (#3719) * provide an alternative to mapfile for older bash (#3717) * Attempt to quiet some warnings with cray compilers. (#3724) * Fix CMake VOL passthrough tests by copying files to correct directory (#3721) * Develop intel split (#3722) * Split intel compiler flags into sub-folders * Update Intel options for warnings * Mostly CMake, Autotools needs additional work * Fixes and adjustments to t_filters_parallel (#3714) Broadcast number of datasets to create in multi-dataset I/O cases so that interference with random number generation doesn't cause mismatches between ranks Set fill time for datasets to "never" by default and adjust on a per-test basis to avoid writing fill values to chunks when it's unnecessary Reduce number of loops run in some tests when performing multi-dataset I/O Fix an issue in the "fill time never" test where data verification could fill if file space reuse causes application buffers to be filled with chosen fill value when reading from datasets with uninitialized storage Skip multi-chunk I/O test configurations for multi-dataset I/O configurations when the TestExpress level is > 1 since those tests can be more stressful on the file system Disable use of persistent file free space management for now since it occasionally runs into an infinite loop in the library's free space management code * Suppress cast-qual warning in H5TB Fortran wrapper (#3728) This interface is fundamentally broken, const-wise. * Add new API function H5Pget_actual_select_io_mode() (#2974) This function allows the user to determine if the library performed selection I/O, vector I/O, or scalar (legacy) I/O during the last HDF5 operation performed with the provided DXPL. Expanded existing tests to check this functionality. * Test scripts now execute in-source with creation of tmp dir (#3723) Fixes a few issues created in #3580: * Fixes a problem where committed tools test files were deleted when cleaning after an in-source build * Fixes issues with test file paths in Autotools tools test scripts * Add -h and --help as flags in h5cc & h5fc (#3729) Adds these common help flags in addition to -help * Update the library version matrix for H5Pset_libver_bounds() (#3702) * Fixed #3524 Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs. * Remove references to LIBVER_V116 --------- Co-authored-by: H. Joe Lee <hyoklee@hdfgroup.org> Co-authored-by: Allen Byrne <50328838+byrnHDF@users.noreply.github.com> Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org> Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com> Co-authored-by: Neil Fortner <fortnern@gmail.com> Co-authored-by: Glenn Song <43005495+glennsong09@users.noreply.github.com> Co-authored-by: bmribler <39579120+bmribler@users.noreply.github.com>
This function allows the user to determine if the library performed selection I/O, vector I/O, or scalar (legacy) I/O during the last HDF5 operation performed with the provided DXPL. Expanded existing tests to check this functionality.